|
|
Rank: Fanatic
Joined: 7/25/2006
Posts: 393
Location: Silkeborg, Denmark
|
Whenever I use IE7 to insert links, the frontend displays them as http://mydevserver/%7BlocalLink:1154%7D If I use IE6 to insert links it works fine. Anyone else get this bug or have a fix for it (other than reverting back to IE6)? I'm using Umbraco 2.1.4. Best regards, Soeren Sprogoe
Brug for råd til hvordan du driver en god webshop? / Need advice on how to run an effective webshop?
|
|
Rank: Aficionado
Joined: 7/19/2006
Posts: 188
Location: Norway
|
Hey
I'm getting this too with IE7. I spoke to Niels about it and he said it's due to some old javascript that needs to be replaced.
Daniel
|
|
Rank: Fanatic
Joined: 7/25/2006
Posts: 393
Location: Silkeborg, Denmark
|
Bug is still here in Umbraco 2.1.5 and IE7 RC1. Daniel, can you be more specific as to which javascript needs to be updated and perhabs with what?
Brug for råd til hvordan du driver en god webshop? / Need advice on how to run an effective webshop?
|
|
Rank: Fanatic
Joined: 7/25/2006
Posts: 393
Location: Silkeborg, Denmark
|
Okay, I've made a temporary fix for the problem, you can find it here: http://www.bluebook.dk/umbraco/editorBarFunctions.zipExtract the .js file and copy it to the /umbraco/js directory. Notice: This is a hack, NOT A FIX! Opening up an internal link in a new window still doesn't work, however external links should work. The original version uses the textRange.pasteHTML function for inserting the link, and apparently IE7 tries to be "smart" when you paste HTML: It sees that the link is not a real URL and tries to fix it. I've replaced .pasteHTML with document.execCommand('CreateLink'), but I'm having problems with getting this command to insert additional <A> attributes like target=_blank.
Brug for råd til hvordan du driver en god webshop? / Need advice on how to run an effective webshop?
|
|
Rank: Devotee
Joined: 8/2/2006
Posts: 47
|
Its worth patching this up in the next release as IE7 is going to be pushed as a majour update to all windows boxes via MS update. I can just imagine the clients ringing now...
Mike
|
|
Rank: Fanatic
Joined: 7/25/2006
Posts: 393
Location: Silkeborg, Denmark
|
True. I'm actually surprised that not that many people allready are running IE7 since it's currently out in a release candidate. It's really a minor job to fix the problem, I just don't have the time or DOM knowledge to do it myself. Allready played around with it a couple of hours before I gave up and learned to live with the fact that opening internal links in new windows doesn't work. But how do I go about reporting this as an official bug? So we can get progress on it registered and the problem prioritized?
Brug for råd til hvordan du driver en god webshop? / Need advice on how to run an effective webshop?
|
|
Rank: Fanatic
Joined: 7/20/2006
Posts: 449
Location: NL
|
Soeren Sprogoe wrote:
It's really a minor job to fix the problem
I've been playing around with it a bit, but it might not be that easy as you claim Soeren...... It seems that every special character can be placed with the pasteHTML function except for the {} If you use the escaped characters (& #91; being [) they get placed correctly in the editor. And what do you know....EXCEPT for the {} characters......they always end up as %7b and %7d. Perhaphs it is an option to rewrite the 'ParseInternalLinks' to also replace the %7b localLinks? I tried, not the nicest way to solve but it worked.
Working on an events-calendar with recursion. Post requests on my blog!
|
|
Rank: Addict
Joined: 3/17/2008
Posts: 812
Location: Nyborg, Denmark
|
v3 features a whole new editor, so the old one will not be maintained any more. The new one works fine with ie7 (and firefox)
Jeeeez, did I really start this :-)
|
|
Rank: Fanatic
Joined: 7/20/2006
Posts: 449
Location: NL
|
Hm, guess it was easy solved after all then :D
Working on an events-calendar with recursion. Post requests on my blog!
|
|
Rank: Fanatic
Joined: 7/20/2006
Posts: 449
Location: NL
|
Hm, I actually did find something usefull.....which solves the problem. As addition to you Soeren, you can now also open in new window. Download the new js-file. What I added is this: Code:
if (rng.parentElement().tagName == "A"){
rng.parentElement().target="_blank";
}
Working on an events-calendar with recursion. Post requests on my blog!
|
|
Rank: Enthusiast
Joined: 8/11/2006
Posts: 12
|
Soeren Sprogoe wrote:
True. I'm actually surprised that not that many people allready are running IE7 since it's currently out in a release candidate.
Because it's only techies like us that upgrade - regular users (what evet that is :hmm:) never upgrade before they arre forced to. If it ain't broken, don't fit it :roll: And thank god for that release candidate is SO NOT a final version. Even though we have had customers that complained that their webpage didn't work on IE7 beta 1-2. But... We NEVER optimize for beta/release candidates, unless we are paid very fine to do it. Waste of time. What sucks offcourse is that it is practically impossible to remove IE7 after installing it, and going back to IE 6 (sad sad personal experience). ...a fix would be nice though - stuck on IE 7 myself, and can't switch back to IE6 :mad:
"Obstacles are those frightful things you see when you take your eyes off your goal."
|
|
Rank: Administration
Joined: 7/25/2006
Posts: 413
Location: vipperoed, denmark
|
Niels Hartvig wrote:
v3 features a whole new editor, so the old one will not be maintained any more. The new one works fine with ie7 (and firefox)
Looking forward to V3 :dribble: but it would be very cool this could be fixed in 2.1x since not everybody is upgrading production systems to 3.0 right away. Can anyone fix this? Is it quick and dirty or does it require sponsoring? I'll throw in some if it's needed. Kindly Jesper
webbureau jesper.com doing webdesign / development / umbraco implementations / 2007&2008 MVP
|
|
Rank: Fanatic
Joined: 7/20/2006
Posts: 449
Location: NL
|
Have you read my post Jesper? (2 or 3 posts above here)
Quick and dirty fix based on the earlier post that Soeren did here.
Only the js-file needs updating and then it works for IE7.
Working on an events-calendar with recursion. Post requests on my blog!
|
|
Rank: Administration
Joined: 7/25/2006
Posts: 413
Location: vipperoed, denmark
|
Peter Dijksterhuis wrote:
Have you read my post Jesper? (2 or 3 posts above here)
Quick and dirty fix based on the earlier post that Soeren did here.
Only the js-file needs updating and then it works for IE7.
Sry :) I have re-read it and will try it out. Thanks Peter. At first I was under the impression that it was only partly fixing the problem. Kindly Jesper
webbureau jesper.com doing webdesign / development / umbraco implementations / 2007&2008 MVP
|
|
Rank: Fanatic
Joined: 7/20/2006
Posts: 449
Location: NL
|
I've tested it, and I didn't come across weird things, so I guess it is working good.
If it turns out to be not working, than I do have an alternative fix for it too, but that required altering the code. If anyone is interested, I could post the dll or the source-code.
Working on an events-calendar with recursion. Post requests on my blog!
|
|
Rank: Administration
Joined: 7/25/2006
Posts: 413
Location: vipperoed, denmark
|
|
|
Rank: Fanatic
Joined: 7/20/2006
Posts: 449
Location: NL
|
Hm, hate to disappoint you, but it only works on new links.....
If you edit a page that has localLinks in it and then save and publish, the localLinks are messed up again.....
I just found out on my own blog.
Only way to go would be to alter the code a bit I guess.
Working on an events-calendar with recursion. Post requests on my blog!
|
|
Rank: Addict
Joined: 7/29/2006
Posts: 504
Location: Melbourne, Australia
|
Peter Dijksterhuis wrote:
Hm, hate to disappoint you, but it only works on new links.....
If you edit a page that has localLinks in it and then save and publish, the localLinks are messed up again.....
Is there a way to fix this (eg: recreate all links after the patch is applied)? With IE7 officially released now, this will quickly become a big pain in the bum for all Umbraco developers with clients who update their own sites.. luckily i only have 1 so far, but still don't want to have to do all their udpates for them. :( do we have a plan of attack for this problem? (besides v3, which will be beta for a while, so best not used in production environments, right?)
Wishes he could work with Umbraco all the time.
|
|
Rank: Addict
Joined: 7/29/2006
Posts: 504
Location: Melbourne, Australia
|
Ah, sorry guys i just found this post: http://forum.umbraco.org/4981#post-4981 i saw it in search results but couldn't access it... still some bugs in the forum. :(
Wishes he could work with Umbraco all the time.
|
|
Rank: Aficionado
Joined: 7/19/2006
Posts: 155
|
Hi A quick fix created by Niels can be downloaded here: http://www.cpalm.dk/media/2618/umbraco.editorcontrols.dll.zip (it's not a zip file) I guess it is not a official patch, but it works perfectly :-) Download and DELETE the .ZIP from the file name and replace the file located in the /bin folder It's a simple replace, that are fixing the issue in IE7 here: umbraco.editorControls.wysiwyg.editor.Save() Code:this._text = this._text.Replace("%7BlocalLink", "{localLink").Replace("%7D\"", "}\""); Regards/Christian http://www.cpalm.dk
CPalm, www.cpalm.dk
|
|
|
Guest |